linux-kernel - Re: [PATCH 2/2] crash_core: fix out-of-bounds access check in crash_exclude_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231218092902.9fae480cfcad3874e9e7236f@linux-foundation.org>
Date: Mon, 18 Dec 2023 09:29:02 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Yuntao Wang <ytcoode@...il.com>
Cc: linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, x86@...nel.org,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Baoquan He <bhe@...hat.com>, Vivek Goyal
 <vgoyal@...hat.com>, Dave Young <dyoung@...hat.com>, Hari Bathini
 <hbathini@...ux.ibm.com>, Sean Christopherson <seanjc@...gle.com>, Takashi
 Iwai <tiwai@...e.de>
Subject: Re: [PATCH 2/2] crash_core: fix out-of-bounds access check in
 crash_exclude_mem_range()

On Mon, 18 Dec 2023 16:19:15 +0800 Yuntao Wang <ytcoode@...il.com> wrote:

> mem->nr_ranges represents the current number of elements stored in
> the mem->ranges array, and mem->max_nr_ranges represents the maximum number
> of elements that the mem->ranges array can hold. Therefore, the correct
> array out-of-bounds check should be mem->nr_ranges >= mem->max_nr_ranges.
> 

This does not apply after your own "crash_core: fix and simplify the
logic of crash_exclude_mem_range()".  What should be done?