lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231218010926.10e15c57@minigeek.lan> Date: Mon, 18 Dec 2023 01:09:26 +0000 From: Andre Przywara <andre.przywara@....com> To: Maksim Kiselev <bigunclemax@...il.com> Cc: Vasily Khoruzhick <anarsoul@...il.com>, Yangtao Li <tiny.windzz@...il.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Marc Kleine-Budde <mkl@...gutronix.de>, John Watts <contact@...kia.org>, Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org Subject: Re: [PATCH v6 3/3] riscv: dts: allwinner: d1: Add thermal sensor On Mon, 18 Dec 2023 00:06:24 +0300 Maksim Kiselev <bigunclemax@...il.com> wrote: Hi, > From: Maxim Kiselev <bigunclemax@...il.com> > > This patch adds a thermal sensor controller node for the D1/T113s. > Also it adds a THS calibration data cell to efuse node. > > Signed-off-by: Maxim Kiselev <bigunclemax@...il.com> > --- > .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > index 5a9d7f5a75b4..6f5427d9cfbf 100644 > --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > @@ -166,6 +166,19 @@ gpadc: adc@...9000 { > #io-channel-cells = <1>; > }; > > + ths: thermal-sensor@...9400 { > + compatible = "allwinner,sun20i-d1-ths"; > + reg = <0x02009400 0x400>; > + interrupts = <SOC_PERIPHERAL_IRQ(58) IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_BUS_THS>; > + clock-names = "bus"; > + resets = <&ccu RST_BUS_THS>; > + nvmem-cells = <&ths_calibration>; > + nvmem-cell-names = "calibration"; > + status = "disabled"; Any reason this is disabled? We typically don't disable those internal devices in the SoC .dtsi, the THS is one example (check the instances in other SoCs' .dtsi files). The rest looks alright, compared to the manual, so with this line removed: Reviewed-by: Andre Przywara <andre.przywara@....com> Cheers, Andre > + #thermal-sensor-cells = <0>; > + }; > + > dmic: dmic@...1000 { > compatible = "allwinner,sun20i-d1-dmic", > "allwinner,sun50i-h6-dmic"; > @@ -415,6 +428,10 @@ sid: efuse@...6000 { > reg = <0x3006000 0x1000>; > #address-cells = <1>; > #size-cells = <1>; > + > + ths_calibration: thermal-sensor-calibration@14 { > + reg = <0x14 0x4>; > + }; > }; > > crypto: crypto@...0000 {
Powered by blists - more mailing lists