linux-kernel - arch/arm/mach-sa1100/ssp.c:89: warning: Function parameter or struct member 'data' not described in 'ssp_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202312190124.XlzGTotA-lkp@intel.com>
Date: Tue, 19 Dec 2023 01:40:59 +0800
From: kernel test robot <lkp@...el.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: arch/arm/mach-sa1100/ssp.c:89: warning: Function parameter or struct
 member 'data' not described in 'ssp_read_word'

Hi Arnd,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ceb6a6f023fd3e8b07761ed900352ef574010bcb
commit: 8faf91c48ca20c714e0dd8cc5f510e3819852912 ARM: sa1100: un-deprecate jornada720
date:   11 months ago
config: arm-jornada720_defconfig (https://download.01.org/0day-ci/archive/20231219/202312190124.XlzGTotA-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231219/202312190124.XlzGTotA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312190124.XlzGTotA-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/arm/mach-sa1100/ssp.c:89: warning: Function parameter or struct member 'data' not described in 'ssp_read_word'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SA1100_SSP
   Depends on [n]: ARCH_SA1100 [=y] && UNUSED_BOARD_FILES [=n]
   Selected by [y]:
   - SA1100_JORNADA720_SSP [=y] && ARCH_SA1100 [=y] && SA1100_JORNADA720 [=y]


vim +89 arch/arm/mach-sa1100/ssp.c

^1da177e4c3f41 Linus Torvalds  2005-04-16   72  
^1da177e4c3f41 Linus Torvalds  2005-04-16   73  /**
^1da177e4c3f41 Linus Torvalds  2005-04-16   74   * ssp_read_word - read a word from the SSP port
^1da177e4c3f41 Linus Torvalds  2005-04-16   75   *
^1da177e4c3f41 Linus Torvalds  2005-04-16   76   * Wait for a data word in the SSP receive FIFO, and return the
^1da177e4c3f41 Linus Torvalds  2005-04-16   77   * received data.  Data is LSB justified.
^1da177e4c3f41 Linus Torvalds  2005-04-16   78   *
^1da177e4c3f41 Linus Torvalds  2005-04-16   79   * Note: Currently, if data is not expected to be received, this
^1da177e4c3f41 Linus Torvalds  2005-04-16   80   * function will wait for ever.
^1da177e4c3f41 Linus Torvalds  2005-04-16   81   *
^1da177e4c3f41 Linus Torvalds  2005-04-16   82   * The caller is expected to perform the necessary locking.
^1da177e4c3f41 Linus Torvalds  2005-04-16   83   *
^1da177e4c3f41 Linus Torvalds  2005-04-16   84   * Returns:
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   85   *   %-ETIMEDOUT	timeout occurred
^1da177e4c3f41 Linus Torvalds  2005-04-16   86   *   16-bit data	success
^1da177e4c3f41 Linus Torvalds  2005-04-16   87   */
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   88  int ssp_read_word(u16 *data)
^1da177e4c3f41 Linus Torvalds  2005-04-16  @89  {
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   90  	int timeout = TIMEOUT;
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   91  
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   92  	while (!(Ser4SSSR & SSSR_RNE)) {
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   93  	        if (!--timeout)
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   94  	        	return -ETIMEDOUT;
^1da177e4c3f41 Linus Torvalds  2005-04-16   95  		cpu_relax();
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   96  	}
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   97  
8f1bf8743c4593 Paul Sokolovsky 2006-08-27   98  	*data = (u16)Ser4SSDR;
^1da177e4c3f41 Linus Torvalds  2005-04-16   99  
8f1bf8743c4593 Paul Sokolovsky 2006-08-27  100  	return 0;
^1da177e4c3f41 Linus Torvalds  2005-04-16  101  }
^1da177e4c3f41 Linus Torvalds  2005-04-16  102  

:::::: The code at line 89 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki