linux-kernel - Re: [PATCH v5 3/3] x86/kexec: use pr_err() instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231218102436.4378f51a36525ce770f6cd30@linux-foundation.org>
Date: Mon, 18 Dec 2023 10:24:36 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Yuntao Wang <ytcoode@...il.com>
Cc: linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, x86@...nel.org,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Jonathan Corbet <corbet@....net>, Eric
 Biederman <ebiederm@...ssion.com>, Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH v5 3/3] x86/kexec: use pr_err() instead of pr_debug()
 when an error occurs

On Sun, 17 Dec 2023 11:35:28 +0800 Yuntao Wang <ytcoode@...il.com> wrote:

> When an error is detected, use pr_err() instead of pr_debug() to output
> log message.
> 
> In addition, remove the unnecessary return from set_page_address().
> 
> ...
>
> --- a/arch/x86/kernel/kexec-bzimage64.c
> +++ b/arch/x86/kernel/kexec-bzimage64.c
> @@ -424,7 +424,7 @@ static void *bzImage64_load(struct kimage *image, char *kernel,
>  	 * command line. Make sure it does not overflow
>  	 */
>  	if (cmdline_len + MAX_ELFCOREHDR_STR_LEN > header->cmdline_size) {
> -		pr_debug("Appending elfcorehdr=<addr> to command line exceeds maximum allowed length\n");
> +		pr_err("Appending elfcorehdr=<addr> to command line exceeds maximum allowed length\n");
>  		return ERR_PTR(-EINVAL);
>  	}

https://lkml.kernel.org/r/20231213055747.61826-4-bhe@redhat.com has
already changed this to call kexec_dprintk().  I'll skip this patch.