linux-kernel - Re: [PATCH v10 18/41] ALSA: usb-audio: qcom: Add USB QMI definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a3a6277-62f6-2d6c-d36a-46a442c89b67@quicinc.com>
Date: Mon, 18 Dec 2023 11:58:02 -0800
From: Wesley Cheng <quic_wcheng@...cinc.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, <srinivas.kandagatla@...aro.org>,
        <mathias.nyman@...el.com>, <perex@...ex.cz>, <conor+dt@...nel.org>,
        <corbet@....net>, <gregkh@...uxfoundation.org>, <lgirdwood@...il.com>,
        <andersson@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <konrad.dybcio@...aro.org>, <Thinh.Nguyen@...opsys.com>,
        <broonie@...nel.org>, <bgoswami@...cinc.com>, <tiwai@...e.com>,
        <robh+dt@...nel.org>, <agross@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-sound@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <alsa-devel@...a-project.org>
Subject: Re: [PATCH v10 18/41] ALSA: usb-audio: qcom: Add USB QMI definitions

Hi Jeff,

On 12/15/2023 2:38 PM, Jeff Johnson wrote:
> On 12/15/2023 1:49 PM, Wesley Cheng wrote:
>> The Qualcomm USB audio offload driver utilizes the QMI protocol to
>> communicate with the audio DSP.  Add the necessary QMI header and field
>> definitions, so the QMI interface driver is able to route the QMI packet
>> received to the USB audio offload driver.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
>> ---
>>   sound/usb/qcom/usb_audio_qmi_v01.c | 892 +++++++++++++++++++++++++++++
>>   sound/usb/qcom/usb_audio_qmi_v01.h | 162 ++++++
>>   2 files changed, 1054 insertions(+)
>>   create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.c
>>   create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.h
>>
>> diff --git a/sound/usb/qcom/usb_audio_qmi_v01.c b/sound/usb/qcom/usb_audio_qmi_v01.c
>> new file mode 100644
>> index 000000000000..bdfd67d980eb
>> --- /dev/null
>> +++ b/sound/usb/qcom/usb_audio_qmi_v01.c
>> @@ -0,0 +1,892 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +#include <linux/soc/qcom/qmi.h>
>> +
>> +#include "usb_audio_qmi_v01.h"
>> +
>> +static struct qmi_elem_info mem_info_v01_ei[] = {
> 
> I believe all of the struct qmi_elem_info arrays can be const.
> 
> At least that was the goal of commit ff6d365898d4 ("soc: qcom: qmi: use
> const for struct qmi_elem_info")
> 

Thanks for the review.  Will fix this.

Thanks
Wesley Cheng