linux-kernel - Re: [PATCH v1] perf tests: Make DSO tests a suite rather than individual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZYCsMpYtmsQr1_Ed@kernel.org>
Date: Mon, 18 Dec 2023 17:31:46 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@....com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Yang Jihong <yangjihong1@...wei.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf tests: Make DSO tests a suite rather than
 individual

Em Tue, Nov 28, 2023 at 11:46:24AM -0800, Ian Rogers escreveu:
> Make the DSO data tests a suite rather than individual so their output
> is grouped.

Thanks, applied to perf-tools-next.

- Arnaldo

 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/builtin-test.c |  2 --
>  tools/perf/tests/dso-data.c     | 15 ++++++++++++---
>  2 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 113e92119e1d..9c09e4681c3a 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -62,8 +62,6 @@ static struct test_suite *generic_tests[] = {
>  	&suite__pmu,
>  	&suite__pmu_events,
>  	&suite__dso_data,
> -	&suite__dso_data_cache,
> -	&suite__dso_data_reopen,
>  	&suite__perf_evsel__roundtrip_name_test,
>  #ifdef HAVE_LIBTRACEEVENT
>  	&suite__perf_evsel__tp_sched_test,
> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
> index deaefcdd8f09..5286ae8bd2d7 100644
> --- a/tools/perf/tests/dso-data.c
> +++ b/tools/perf/tests/dso-data.c
> @@ -393,6 +393,15 @@ static int test__dso_data_reopen(struct test_suite *test __maybe_unused, int sub
>  	return 0;
>  }
>  
> -DEFINE_SUITE("DSO data read", dso_data);
> -DEFINE_SUITE("DSO data cache", dso_data_cache);
> -DEFINE_SUITE("DSO data reopen", dso_data_reopen);
> +
> +static struct test_case tests__dso_data[] = {
> +	TEST_CASE("read", dso_data),
> +	TEST_CASE("cache", dso_data_cache),
> +	TEST_CASE("reopen", dso_data_reopen),
> +	{	.name = NULL, }
> +};
> +
> +struct test_suite suite__dso_data = {
> +	.desc = "DSO data tests",
> +	.test_cases = tests__dso_data,
> +};
> -- 
> 2.43.0.rc1.413.gea7ed67945-goog
> 

-- 

- Arnaldo