linux-kernel - Re: [PATCH v1 10/14] perf top: Avoid repeated function calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 17:34:54 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: James Clark <james.clark@....com>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...aro.org>,
	John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>,
	André Almeida <andrealmeid@...lia.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	K Prateek Nayak <kprateek.nayak@....com>,
	Sean Christopherson <seanjc@...gle.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Kajol Jain <kjain@...ux.ibm.com>,
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	Andrew Jones <ajones@...tanamicro.com>,
	Alexandre Ghiti <alexghiti@...osinc.com>,
	Atish Patra <atishp@...osinc.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	Yang Jihong <yangjihong1@...wei.com>,
	Yang Li <yang.lee@...ux.alibaba.com>,
	Changbin Du <changbin.du@...wei.com>,
	Sandipan Das <sandipan.das@....com>,
	Ravi Bangoria <ravi.bangoria@....com>,
	Paran Lee <p4ranlee@...il.com>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Yanteng Si <siyanteng@...ngson.cn>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
	bpf@...r.kernel.org
Subject: Re: [PATCH v1 10/14] perf top: Avoid repeated function calls

Em Tue, Dec 12, 2023 at 03:11:53PM +0000, James Clark escreveu:
> 
> 
> On 29/11/2023 06:02, Ian Rogers wrote:
> > Add a local variable to avoid repeated calls to perf_cpu_map__nr.
> > 
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> 
> Reviewed-by: James Clark <james.clark@....com>

Thanks, applied to perf-tools-next.

- Arnaldo

 
> > ---
> >  tools/perf/util/top.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/perf/util/top.c b/tools/perf/util/top.c
> > index be7157de0451..4db3d1bd686c 100644
> > --- a/tools/perf/util/top.c
> > +++ b/tools/perf/util/top.c
> > @@ -28,6 +28,7 @@ size_t perf_top__header_snprintf(struct perf_top *top, char *bf, size_t size)
> >  	struct record_opts *opts = &top->record_opts;
> >  	struct target *target = &opts->target;
> >  	size_t ret = 0;
> > +	int nr_cpus;
> >  
> >  	if (top->samples) {
> >  		samples_per_sec = top->samples / top->delay_secs;
> > @@ -93,19 +94,17 @@ size_t perf_top__header_snprintf(struct perf_top *top, char *bf, size_t size)
> >  	else
> >  		ret += SNPRINTF(bf + ret, size - ret, " (all");
> >  
> > +	nr_cpus = perf_cpu_map__nr(top->evlist->core.user_requested_cpus);
> >  	if (target->cpu_list)
> >  		ret += SNPRINTF(bf + ret, size - ret, ", CPU%s: %s)",
> > -				perf_cpu_map__nr(top->evlist->core.user_requested_cpus) > 1
> > -				? "s" : "",
> > +				nr_cpus > 1 ? "s" : "",
> >  				target->cpu_list);
> >  	else {
> >  		if (target->tid)
> >  			ret += SNPRINTF(bf + ret, size - ret, ")");
> >  		else
> >  			ret += SNPRINTF(bf + ret, size - ret, ", %d CPU%s)",
> > -					perf_cpu_map__nr(top->evlist->core.user_requested_cpus),
> > -					perf_cpu_map__nr(top->evlist->core.user_requested_cpus) > 1
> > -					? "s" : "");
> > +					nr_cpus, nr_cpus > 1 ? "s" : "");
> >  	}
> >  
> >  	perf_top__reset_sample_counters(top);
> 

-- 

- Arnaldo