linux-kernel - Re: [PATCH v4 4/5] dt-bindings: hwmon: Add Amphenol ChipCap 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 14:46:24 -0600
From: Rob Herring <robh@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, linux-doc@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Conor Dooley <conor.dooley@...rochip.com>, Guenter Roeck <linux@...ck-us.net>, Mark Brown <broonie@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>, Liam Girdwood <lgirdwood@...il.com>, devicetree@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v4 4/5] dt-bindings: hwmon: Add Amphenol ChipCap 2


On Mon, 18 Dec 2023 20:10:32 +0100, Javier Carrasco wrote:
> Add device tree bindings and an example for the ChipCap 2 humidity
> and temperature sensor.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  .../bindings/hwmon/amphenol,chipcap2.yaml          | 77 ++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.example.dtb: humidity@28: compatible: 'oneOf' conditional failed, one must be fixed:
	['amphenol,cc2d23s'] is too short
	'amphenol,cc2d23' was expected
	from schema $id: http://devicetree.org/schemas/hwmon/amphenol,chipcap2.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231020-topic-chipcap2-v4-4-7940cfa7613a@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.