linux-kernel - Re: [PATCH v2 3/3] rust: workqueue: add `#[pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1bebeca-858c-4fd5-addd-be55421935ee@gmail.com>
Date: Mon, 18 Dec 2023 17:49:45 -0300
From: Martin Rodriguez Reboredo <yakoyoku@...il.com>
To: Benno Lossin <benno.lossin@...ton.me>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng
 <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl
 <aliceryhl@...gle.com>, Tejun Heo <tj@...nel.org>
Cc: Wedson Almeida Filho <walmeida@...rosoft.com>,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work`

On 12/18/23 14:47, Benno Lossin wrote:
> On 12/14/23 04:13, Martin Rodriguez Reboredo wrote:
>> On 12/13/23 19:09, Benno Lossin wrote:
>>> The previous two patches made it possible to add `#[pin_data]` on
>>> structs with default generic parameter values.
>>> This patch makes `Work` use `#[pin_data]` and removes an invocation of
>>> `pin_init_from_closure`. This function is intended as a low level manual
>>> escape hatch, so it is better to rely on the safe `pin_init!` macro.
>>>
>>> Signed-off-by: Benno Lossin <benno.lossin@...ton.me>
>>> ---
>>> [...]
> 
> Did you mean to add your reviewed by? Because I received only
> the quote.
> 

Thunderbird is a disaster for plain-text emails.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>