linux-kernel - Re: [PATCH v6 00/47] maps/threads/dsos memory improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYCxURwlu7Rld-IW@kernel.org>
Date: Mon, 18 Dec 2023 17:53:37 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Nick Terrell <terrelln@...com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>, Kajol Jain <kjain@...ux.ibm.com>,
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Vincent Whitchurch <vincent.whitchurch@...s.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	Liam Howlett <liam.howlett@...cle.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Colin Ian King <colin.i.king@...il.com>,
	Dmitrii Dolgov <9erthalion6@...il.com>,
	Yang Jihong <yangjihong1@...wei.com>,
	Ming Wang <wangming01@...ngson.cn>,
	James Clark <james.clark@....com>,
	K Prateek Nayak <kprateek.nayak@....com>,
	Sean Christopherson <seanjc@...gle.com>,
	Leo Yan <leo.yan@...aro.org>, Ravi Bangoria <ravi.bangoria@....com>,
	German Gomez <german.gomez@....com>,
	Changbin Du <changbin.du@...wei.com>,
	Paolo Bonzini <pbonzini@...hat.com>, Li Dong <lidong@...o.com>,
	Sandipan Das <sandipan.das@....com>,
	liuwenyu <liuwenyu7@...wei.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	Guilherme Amadio <amadio@...too.org>
Subject: Re: [PATCH v6 00/47] maps/threads/dsos memory improvements and fixes

Em Wed, Dec 06, 2023 at 05:16:34PM -0800, Ian Rogers escreveu:
> Modify the implementation of maps to not use an rbtree as the
> container for maps, instead use a sorted array. Improve locking and
> reference counting issues.
> 
> Similar to maps separate out and reimplement threads to use a hashmap
> for lower memory consumption and faster look up. The fixes a
> regression in memory usage where reference count checking switched to
> using non-invasive tree nodes.  Reduce its default size by 32 times
> and improve locking discipline. Also, fix regressions where tids had
> become unordered to make `perf report --tasks` and
> `perf trace --summary` output easier to read.
> 
> Better encapsulate the dsos abstraction. Remove the linked list and
> rbtree used for faster iteration and log(n) lookup to a sorted array
> for similar performance but half the memory usage per dso. Improve
> reference counting and locking discipline, adding reference count
> checking to dso.
> 
> v6:
>  - Patch 1 is a parameter name fix requested by Namhyung.
>  - Patches 2 to 13 split apart a macro to function callback refactor
>    requested by Arnaldo.
>  - Add fixes and acked-by to later patches from Namhyung.

Applied 1-10, 11 is failing, I'll try to resolve if you don't do it
first.

This should be in tmp.perf-tools-next soon

- Arnaldo