linux-kernel - Re: [PATCH 1/2] crypto: iaa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7250eea-5fde-404e-701a-152b6a609419@intel.com>
Date: Mon, 18 Dec 2023 13:55:22 -0800
From: Fenghua Yu <fenghua.yu@...el.com>
To: Tom Zanussi <tom.zanussi@...ux.intel.com>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>
CC: <dave.jiang@...el.com>, <tony.luck@...el.com>, <jacob.jun.pan@...el.com>,
	<christophe.jaillet@...adoo.fr>, <linux-kernel@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>, <dmaengine@...r.kernel.org>
Subject: Re: [PATCH 1/2] crypto: iaa - Change desc->priv to 0



On 12/18/23 12:47, Tom Zanussi wrote:
> In order for shared workqeues to work properly, desc->priv should be
> set to 0 rather than 1.  The need for this is described in commit
> f5ccf55e1028 (dmaengine/idxd: Re-enable kernel workqueue under DMA
> API), so we need to make IAA consistent with IOMMU settings, otherwise
> we get:
> 
>    [  141.948389] IOMMU: dmar15: Page request in Privilege Mode
>    [  141.948394] dmar15: Invalid page request: 2000026a100101 ffffb167
> 
> Dedicated workqueues ignore this field and are unaffected.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

Thanks.

-Fenghua