linux-kernel - Re: [PATCH v11 00/10] spi: Add support for stacked/parallel memories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 23:10:20 +0100 (CET)
From: Richard Weinberger <richard@....at>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>
Cc: Mark Brown <broonie@...nel.org>, Tudor Ambarus <tudor.ambarus@...aro.org>, 
	pratyush <pratyush@...nel.org>, 
	Miquel Raynal <miquel.raynal@...tlin.com>, 
	Vignesh Raghavendra <vigneshr@...com>, 
	sbinding@...nsource.cirrus.com, Lee Jones <lee@...nel.org>, 
	james schulman <james.schulman@...rus.com>, 
	david rhodes <david.rhodes@...rus.com>, rf@...nsource.cirrus.com, 
	Jaroslav Kysela <perex@...ex.cz>, tiwai@...e.com, 
	linux-spi <linux-spi@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	Michael Walle <michael@...le.cc>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	Nicolas Ferre <nicolas.ferre@...rochip.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, 
	Claudiu Beznea <claudiu.beznea@...on.dev>, 
	michal simek <michal.simek@....com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	alsa-devel <alsa-devel@...a-project.org>, 
	patches@...nsource.cirrus.com, linux-sound@...r.kernel.org, 
	git@....com, amitrkcian2002@...il.com
Subject: Re: [PATCH v11 00/10] spi: Add support for stacked/parallel
 memories

----- Ursprüngliche Mail -----
> Von: "Amit Kumar Mahapatra" <amit.kumar-mahapatra@....com>

> This patch series updated the spi-nor, spi core and the AMD-Xilinx GQSPI
> driver to add stacked and parallel memories support.

I wish the series had a real cover letter which explains the big picture
in more detail.

What I didn't really get so far, is it really necessary to support multiple
chip selects within a single mtd?
You changes introduce hard to maintain changes into the spi-nor/mtd core code
which alert me.
Why can't we have one mtd for each cs and, if needed, combine them later?
We have drivers such as mtdconcat for reasons.

Thanks,
//richard