linux-kernel - Re: [PATCH 0/3] md: Remove deprecated flavors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231218093201.000020dd@linux.intel.com>
Date: Mon, 18 Dec 2023 09:32:01 +0100
From: Mariusz Tkaczyk <mariusz.tkaczyk@...ux.intel.com>
To: Song Liu <song@...nel.org>
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-block@...r.kernel.org, Paul E Luse <paul.e.luse@...ux.intel.com>
Subject: Re: [PATCH 0/3] md: Remove deprecated flavors

On Fri, 15 Dec 2023 07:37:54 -0800
Song Liu <song@...nel.org> wrote:

> Hi Mariusz,
> 
> On Fri, Dec 15, 2023 at 3:51 AM Mariusz Tkaczyk
> <mariusz.tkaczyk@...ux.intel.com> wrote:
> >
> > On Thu, 14 Dec 2023 14:21:04 -0800
> > Song Liu <song@...nel.org> wrote:
> >  
> > > Linear, multipath, and faulty have been marked as deprecated for 2.5
> > > years. Let's remove them.
> > >
> > > Thanks,
> > > Song  
> >
> > Hi Song,
> > Great idea!
> >
> > Please note that there are mdadm tests for those levels. I can approve it
> > only when mdadm clean-up is merged. Our tests must pass continuously.  
> 
> Is the continuous test result available publicly?

We are working on public CI (Paul owns it). On my side I'm not executing all
tests, IMSM only. In this case it is obvious that mdadm tests will stop passing,
I don't need results to see that. We should keep both mdadm and md compatible.
We are continuously adding new MD regression tests to mdadm (at least Kuai is
doing that) so we should also care about removing things.

> 
> >
> > It is a nice code complexity improvement so let me know if you would
> > like to get my help with mdadm patches.  
> 
> On my local tests with mdadm, I need to make changes to the following
> tests:
> 
> 00linear...
> 00names...
> 00raid0...
> 00readonly...
> 02lineargrow...
> 03r0assem...
> 04r0update...
> 04update-metadata...
> 
> The changes are all straightforward (just remove things related to
> linear/multipath/faulty).
> 

Please do not forgot remove dead code from mdadm. For example simple find
"multipath" (case insensitive) reefers me to multiple places with special
handling for this level. We need to remove it from code and documentation.
Can you handle this too?

Oh and last one, I can't find update for md man in your changes. Could you
please remove those levels from md man?

Thanks,
Mariusz