linux-kernel - Re: [PATCH v2] gpiolib: cleanup for duplicated including

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 09:54:42 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Wang Jinchao <wangjinchao@...sion.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Andy Shevchenko <andy@...nel.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stone.xulei@...sion.com
Subject: Re: [PATCH v2] gpiolib: cleanup for duplicated including

On Mon, Dec 18, 2023 at 8:16 AM Wang Jinchao <wangjinchao@...sion.com> wrote:
>
> Remove second `#include <linux/err.h>`.
> Remove `#include <asm/errno.h>`.
> As they are guaranteed by the global `err.h`.
>
> Signed-off-by: Wang Jinchao <wangjinchao@...sion.com>
> ---
> V2:
>     Revise the comment per Andy's suggestion.
> V1: https://lore.kernel.org/all/202312151645+0800-wangjinchao@xfusion.com/
>
>  include/linux/gpio/driver.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 0aed62f0c633..df6857e579a1 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -701,7 +701,6 @@ int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
>  #else
>
>  #include <asm/bug.h>
> -#include <asm/errno.h>
>
>  static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
>                                               struct irq_domain *domain)
> @@ -789,8 +788,6 @@ int gpio_device_get_base(struct gpio_device *gdev);
>
>  #else /* CONFIG_GPIOLIB */
>
> -#include <linux/err.h>
> -
>  #include <asm/bug.h>
>
>  static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
> --
> 2.40.0
>

Applied, thanks!

Bart