linux-kernel - Re: [PATCH 10/12] selftests/net: Add TCP-AO RST test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 17:11:40 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Dmitry Safonov <dima@...sta.com>
Cc: Shuah Khan <shuah@...nel.org>, David Ahern <dsahern@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Salam Noureddine <noureddine@...sta.com>,
	Bob Gilligan <gilligan@...sta.com>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
	Dmitry Safonov <0x7f454c46@...il.com>
Subject: Re: [PATCH 10/12] selftests/net: Add TCP-AO RST test

On Fri, Dec 15, 2023 at 02:36:24AM +0000, Dmitry Safonov wrote:
> Check that both active and passive reset works and correctly sign
> segments with TCP-AO or don't send RSTs if not possible to sign.
> A listening socket with backlog = 0 gets one connection in accept
> queue, another in syn queue. Once the server/listener socket is
> forcibly closed, client sockets aren't connected to anything.
> In regular situation they would receive RST on any segment, but
> with TCP-AO as there's no listener, no AO-key and unknown ISNs,
> no RST should be sent.
> 
> And "passive" reset, where RST is sent on reply for some segment
> (tcp_v{4,6}_send_reset()) - there use TCP_REPAIR to corrupt SEQ numbers,
> which later results in TCP-AO signed RST, which will be verified and
> client socket will get EPIPE.
> 
> No TCPAORequired/TCPAOBad segments are expected during these tests.
> 
> Sample of the output:
> > # ./rst_ipv4
> > 1..15
> > # 1462[lib/setup.c:254] rand seed 1686611171
> > TAP version 13
> > ok 1 servered 1000 bytes
> > ok 2 Verified established tcp connection
> > ok 3 sk[0] = 7, connection was reset
> > ok 4 sk[1] = 8, connection was reset
> > ok 5 sk[2] = 9
> > ok 6 MKT counters are good on server
> > ok 7 Verified established tcp connection
> > ok 8 client connection broken post-seq-adjust
> > ok 9 client connection was reset
> > ok 10 No segments without AO sign (server)
> > ok 11 Signed AO segments (server): 0 => 30
> > ok 12 No segments with bad AO sign (server)
> > ok 13 No segments without AO sign (client)
> > ok 14 Signed AO segments (client): 0 => 30
> > ok 15 No segments with bad AO sign (client)
> > # Totals: pass:15 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: Dmitry Safonov <dima@...sta.com>

Tested-by: Hangbin Liu <liuhangbin@...il.com>