lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231218022319.GC88933@rocinante> Date: Mon, 18 Dec 2023 11:23:19 +0900 From: Krzysztof WilczyĆski <kw@...ux.com> To: Yang Li <yang.lee@...ux.alibaba.com> Cc: lpieralisi@...nel.org, robh@...nel.org, bhelgaas@...gle.com, michal.simek@....com, linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com> Subject: Re: [PATCH -next] PCI: xilinx-xdma: Remove redundant dev_err() Hello, > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/pci/controller/pcie-xilinx-dma-pl.c:688:2-9: line 688 is redundant because platform_get_irq() already prints an error > ./drivers/pci/controller/pcie-xilinx-dma-pl.c:702:2-9: line 702 is redundant because platform_get_irq() already prints an error Applied to controller/xilinx, thank you! [1/1] PCI: xilinx-xdma: Remove redundant dev_err() https://git.kernel.org/pci/pci/c/b642e081f46c Krzysztof
Powered by blists - more mailing lists