linux-kernel - Re: [PATCH v2 2/2] hwmon: (pmbus) Add support for MPS Multi-phase mp2856/mp2857 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 10:43:51 +0800
From: Potin Lai <potin.lai.pt@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>, Mark Brown <broonie@...nel.org>, 
	Joel Stanley <joel@....id.au>, Peter Yin <peteryin.openbmc@...il.com>, 
	Peter Yin <peter.yin@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>, 
	Patrick Williams <patrick@...cx.xyz>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus) Add support for MPS Multi-phase
 mp2856/mp2857 controller

On Sun, Dec 17, 2023 at 11:33 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Tue, Dec 12, 2023 at 12:05:19AM +0800, Potin Lai wrote:
> > From: Peter Yin <peteryin.openbmc@...il.com>
> >
> > Add support for mp2856/mp2857 device from Monolithic Power Systems, Inc.
> > (MPS) vendor. This is a dual-loop, digital, multi-phase,
> > modulation controller.
> >
> > Signed-off-by: Peter Yin <peteryin.openbmc@...il.com>
> > Signed-off-by: Potin Lai <potin.lai.pt@...il.com>
>
> Applied, with reservations (because due to lack of datasheet it is all but
> impossible to validate the code) and several fixups. So this driver comes
> with even less warranty than usual.
>
> CHECK: Alignment should match open parenthesis
> #671: FILE: drivers/hwmon/pmbus/mp2856.c:413:
> +       memcpy(data->max_phases, mp2856_max_phases[data->chip_id],
> +               sizeof(data->max_phases));
>
> CHECK: Please don't use multiple blank lines
> #673: FILE: drivers/hwmon/pmbus/mp2856.c:415:
> +
> +
>
> CHECK: Please don't use multiple blank lines
> #707: FILE: drivers/hwmon/pmbus/mp2856.c:449:
> +
> +
>
> Fix those, and use i2c_get_match_data().
>
> _Please_ run your patches through checkpatch. The above is really
> completely unnecessary and creates unnecessary extra work for others (me).
>
> Guenter

Apologies for missing the style check issue, I will add "--strict"
when running checkpatch.pl in future.
And thank you for fixing the mistakes and applying the driver.

Potin