linux-kernel - Re: [RFC PATCH 8/8] firewire: core: change modalias of unit device with backward incompatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231218124645.GA46034@workstation.local>
Date: Mon, 18 Dec 2023 21:46:45 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: Adam Goldman <adamg@...ox.com>
Cc: linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 8/8] firewire: core: change modalias of unit device
 with backward incompatibility

Hi,

On Mon, Dec 18, 2023 at 02:11:42AM -0800, Adam Goldman wrote:
> Hi,
> 
> On Sun, Dec 17, 2023 at 07:30:12PM +0900, Takashi Sakamoto wrote:
> > +	vendor_directory = search_directory(root_directory, CSR_DIRECTORY | CSR_VENDOR);
> 
> Setting the CSR_DIRECTORY bit here is extraneous since search_directory() also sets it.

Indeed. It is redundant.


Thanks

Takashi Sakamoto