linux-kernel - Re: [PATCH] sched/headers: Remove duplicated struct rq declare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfTPtD-rRsUr+P-vjzMDcKfx8Vnb_vLxjCOb5ZPvF5g2LpVzw@mail.gmail.com>
Date: Mon, 18 Dec 2023 14:51:11 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: WangJinchao <wangjinchao@...sion.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Juri Lelli <juri.lelli@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Daniel Bristot de Oliveira <bristot@...hat.com>, Valentin Schneider <vschneid@...hat.com>, linux-kernel@...r.kernel.org, 
	stone.xulei@...sion.com
Subject: Re: [PATCH] sched/headers: Remove duplicated struct rq declare

On Thu, 7 Dec 2023 at 13:20, WangJinchao <wangjinchao@...sion.com> wrote:
>
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <wangjinchao@...sion.com>

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
>  DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
>  #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
>  struct balance_callback {
>         struct balance_callback *next;
>         void (*func)(struct rq *rq);
> --
> 2.40.0
>