linux-kernel - Re: [PATCH 2/2] iio: pressure: change driver for Honeywell MPR series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYHJ-vkLEiN2sFxv@sunspire>
Date: Tue, 19 Dec 2023 18:51:06 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Angel Iglesias <ang.iglesiasg@...il.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Andreas Klinger <ak@...klinger.de>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH 2/2] iio: pressure: change driver for Honeywell MPR series

On Tue, Dec 19, 2023 at 05:41:25PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 19, 2023 at 03:02:21PM +0200, Petre Rodan wrote:
> > ChangeLog
> >  - rewrite flow so that driver can use either i2c or spi as communication bus
> >  - add spi driver (tested on MPRLS0015PA0000SA)
> >  - add pressure-triplet property that automatically sets pmin, pmax
> >  - fix transfer-function enum typo based on previous review [1]
> >  - fix interrupt example in binding file (FALLING -> RISING edge)
> >  - indentation changes based on previous code reviews
> >  - renamed mpr_read_pressure to mpr_read_conversion since the sensor is
> >    supposed to also provide temperature measuremets
> >    (but I think mine is broken since the raw temperature value is always
> >    0x800000 - so temp reading not currently implemented)
> 
> Changelog...
> 
> > I've been told in the past that the use of mutexes is redundant in these cases
> > so please assess if the guard() from the driver code is required or should be
> > removed.
> 
> A comment...
> 
> > patch uses device_property_match_property_string() from the 'togreg' branch
> 
> Another comment...
> 
> > [1]: https://lore.kernel.org/lkml/20231116-grudge-hankering-b7a71d831b93@squawk/T/
> 
> Some Link: (should it be a tag?)...

it's a reference link that was pointed to within the text above.
it emulates `lynx --dump foo.html`. designed for human reading, sorry if it
broke some parsing script.

> Where is the commit message? Or is this just an intermediate change
> to show what will be in the next version? I'm confused.

the commit message is between the end of the mail header and before the actual
patch. the two comments were also placed for human interaction.
they will be removed later on when we get close to acceptance and someone
replies to them. and yes, the entire patch is full and self-contained in these
3 messages.

very best regards,
peter

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)