linux-kernel - RE: [PATCH] driver core: mark remaining local bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 18:02:33 +0000
From: "Ertman, David M" <david.m.ertman@...el.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "rafael@...nel.org"
	<rafael@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "Weiny, Ira" <ira.weiny@...el.com>, William Breathitt Gray
	<william.gray@...aro.org>, David Hildenbrand <david@...hat.com>, "Oscar
 Salvador" <osalvador@...e.de>, Kevin Hilman <khilman@...nel.org>, Ulf Hansson
	<ulf.hansson@...aro.org>, "Brown, Len" <len.brown@...el.com>
Subject: RE: [PATCH] driver core: mark remaining local bus_type variables as
 const

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Sent: Tuesday, December 19, 2023 7:35 AM
> To: rafael@...nel.org; linux-kernel@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Ertman, David M
> <david.m.ertman@...el.com>; Weiny, Ira <ira.weiny@...el.com>; William
> Breathitt Gray <william.gray@...aro.org>; David Hildenbrand
> <david@...hat.com>; Oscar Salvador <osalvador@...e.de>; Kevin Hilman
> <khilman@...nel.org>; Ulf Hansson <ulf.hansson@...aro.org>; Brown, Len
> <len.brown@...el.com>
> Subject: [PATCH] driver core: mark remaining local bus_type variables as
> const
> 
> Now that the driver core can properly handle constant struct bus_type,
> change the local driver core bus_type variables to be a constant
> structure as well, placing them into read-only memory which can not be
> modified at runtime.
> 
> Cc: Dave Ertman <david.m.ertman@...el.com>
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: William Breathitt Gray <william.gray@...aro.org>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Oscar Salvador <osalvador@...e.de>
> Cc: Kevin Hilman <khilman@...nel.org>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Len Brown <len.brown@...el.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/base/auxiliary.c    | 2 +-
>  drivers/base/isa.c          | 2 +-
>  drivers/base/memory.c       | 2 +-
>  drivers/base/node.c         | 2 +-
>  drivers/base/power/domain.c | 2 +-
>  drivers/base/soc.c          | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index 4d4c2c8d26c4..d3a2c40c2f12 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -244,7 +244,7 @@ static void auxiliary_bus_shutdown(struct device
> *dev)
>  		auxdrv->shutdown(auxdev);
>  }
> 
> -static struct bus_type auxiliary_bus_type = {
> +static const struct bus_type auxiliary_bus_type = {
>  	.name = "auxiliary",
>  	.probe = auxiliary_bus_probe,
>  	.remove = auxiliary_bus_remove,
> diff --git a/drivers/base/isa.c b/drivers/base/isa.c
> index 675ad3139224..e23d0b49a793 100644
> --- a/drivers/base/isa.c
> +++ b/drivers/base/isa.c

LGTM - ACK

DaveE