linux-kernel - RE: [RFT 1/2] RISC-V: handle missing "no-map" properties for OpenSBI's PMP protected regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 10:06:48 -0800 (PST)
From: Palmer Dabbelt <palmer@...belt.com>
To: prabhakar.mahadev-lad.rj@...renesas.com
CC: Conor Dooley <conor@...nel.org>, Conor Dooley <conor.dooley@...rochip.com>,
  prabhakar.csengg@...il.com, geert+renesas@...der.be, Atish Patra <atishp@...osinc.com>,
  Paul Walmsley <paul.walmsley@...ive.com>, apatel@...tanamicro.com, alexghiti@...osinc.com,
  Bjorn Topel <bjorn@...osinc.com>, suagrfillet@...il.com, jeeheng.sia@...rfivetech.com,
  petrtesarik@...weicloud.com, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
  stable@...r.kernel.org
Subject:     RE: [RFT 1/2] RISC-V: handle missing "no-map" properties for OpenSBI's PMP protected regions

On Tue, 19 Dec 2023 09:27:42 PST (-0800), prabhakar.mahadev-lad.rj@...renesas.com wrote:
> Hi Conor,
> 
>> -----Original Message-----
>> From: Conor Dooley <conor@...nel.org>
>> Sent: Tuesday, December 19, 2023 5:18 PM
>> To: Conor Dooley <conor.dooley@...rochip.com>
>> Cc: Lad, Prabhakar <prabhakar.csengg@...il.com>; Palmer Dabbelt <palmer@...belt.com>;
>> geert+renesas@...der.be; Atish Patra <atishp@...osinc.com>; Paul Walmsley <paul.walmsley@...ive.com>;
>> apatel@...tanamicro.com; alexghiti@...osinc.com; Bjorn Topel <bjorn@...osinc.com>;
>> suagrfillet@...il.com; jeeheng.sia@...rfivetech.com; petrtesarik@...weicloud.com; linux-
>> riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; stable@...r.kernel.org; Prabhakar Mahadev Lad
>> <prabhakar.mahadev-lad.rj@...renesas.com>
>> Subject: Re: [RFT 1/2] RISC-V: handle missing "no-map" properties for OpenSBI's PMP protected regions
>> 
>> Hey,
>> 
>> On Thu, Dec 07, 2023 at 01:11:23PM +0000, Conor Dooley wrote:
>> > On Thu, Dec 07, 2023 at 01:02:00PM +0000, Lad, Prabhakar wrote:
>> > > On Wed, Dec 6, 2023 at 2:26 PM Conor Dooley <conor@...nel.org> wrote:
>> > > > On Wed, Dec 06, 2023 at 04:52:11AM -0800, Palmer Dabbelt wrote:
>> > > > > On Thu, 10 Aug 2023 02:07:10 PDT (-0700), Conor Dooley wrote:
>> >
>> > > > > > I'm perfectly happy to drop this series though, if people
>> > > > > > generally are of the opinion that this sort of firmware workaround is ill-advised.
>> > > > > > We are unaffected by it, so I certainly have no pressure to
>> > > > > > have something working here. It's my desire not to be
>> > > > > > user-hostile that motivated this patch.
>> > > > >
>> > > > > IIUC you guys and Reneas are the only ones who have hardware
>> > > > > that might be in a spot where users aren't able to update the
>> > > > > firmware (ie, it's out in production somewhere).
>> > > >
>> > > > I dunno if we can really keep thinking like that though. In terms
>> > > > of people who have devicetrees in the kernel and stuff available
>> > > > in western catalog distribution, sure.
>> > > > I don't think we can assume that that covers all users though,
>> > > > certainly the syntacore folks pop up every now and then, and I
>> > > > sure hope that Andes etc have larger customer bases than the
>> > > > in-kernel users would suggest.
>> > > >
>> > > > > So I'm adding Geert, though he probably saw this months ago...
>> > > >
>> > > > Prabhakar might be a good call on that front. I'm not sure if the
>> > > > Renesas stuff works on affected versions of OpenSBI though, guess
>> > > > it depends on the sequencing of the support for the non-coherent
>> > > > stuff and when this bug was fixed.
>> > > >
>> > > ATM, I dont think there are any users who are using the upstream
>> > > kernel + OpenSBI (apart from me and Geert!). Currently the customers
>> > > are using the BSP releases.
>> >
>> > That doesn't really answer whether or not you (and your customers) are
>> > using an affected version of the vendor OpenSBI?
>> > The affected range for OpenSBI itself is [v0.8 to v1.3).
>> 
>> Did you perhaps miss this mail Prabhakar?
>> 
> Oops sorry for that.
> 
> I can confirm the BSP version used by the customers is v1.0 [0].
> 
> [0] https://github.com/renesas-rz/rz_opensbi/commits/work/OpenSBI-PMA/

OK, so sounds like would end up with broken systems from this bug, then?

IIRC we still have the Renesas systems as NONPORTABLE due to that DMA 
pool Kconfig conflict.  So if it's really only these Renesas systems 
that have the bug, maybe we can still remove hibernation from 
NONPORTABLE and just add in some sort of Kconfig to disable the 
Renesas+hibernation combinations that would break?

> 
> Cheers,
> Prabhakar