linux-kernel - Re: [PATCH] tools/thermal/tmon: Fix compilation warning for wrong format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 19:12:42 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Florian Eckert <fe@....tdt.de>, Eckert.Florian@...glemail.com,
 rafael@...nel.org, rui.zhang@...el.com, lukasz.luba@....com
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/thermal/tmon: Fix compilation warning for wrong
 format

On 04/12/2023 15:13, Florian Eckert wrote:
> The following warnings are shown during compilation:
> 
> tui.c: In function 'show_cooling_device':
>   tui.c:216:40: warning: format '%d' expects argument of type 'int', but
> argument 7 has type 'long unsigned int' [-Wformat=]
>     216 |                         "%02d %12.12s%6d %6d",
>         |                                      ~~^
>         |                                        |
>         |                                        int
>         |                                      %6ld
>   ......
>     219 |                         ptdata.cdi[j].cur_state,
>         |                         ~~~~~~~~~~~~~~~~~~~~~~~
>         |                                      |
>         |                                      long unsigned int
>   tui.c:216:44: warning: format '%d' expects argument of type 'int', but
> argument 8 has type 'long unsigned int' [-Wformat=]
>     216 |                         "%02d %12.12s%6d %6d",
>         |                                          ~~^
>         |                                            |
>         |                                            int
>         |                                          %6ld
>   ......
>     220 |                         ptdata.cdi[j].max_state);
>         |                         ~~~~~~~~~~~~~~~~~~~~~~~
>         |                                      |
>         |                                      long unsigned int
> 
> To fix this, the correct string format must be used for printing.
> 
> Signed-off-by: Florian Eckert <fe@....tdt.de>
> ---

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog