linux-kernel - Re: [PATCH] dmaengine: idxd: Remove usage of the deprecated ida_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5d4f9f5-e040-9668-fbbf-dd7b32da9fdb@intel.com>
Date: Tue, 19 Dec 2023 11:09:02 -0800
From: Fenghua Yu <fenghua.yu@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Dave Jiang
	<dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<dmaengine@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: idxd: Remove usage of the deprecated
 ida_simple_xx() API



On 12/18/23 22:28, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
> 
> This is less verbose.
> 
> Note that the upper limit of ida_simple_get() is exclusive, but the one of
> ida_alloc_range() is inclusive. So change this change allows one more

s/change this change/this change/

> device.
> 
> MINORMASK is	((1U << MINORBITS) - 1), so allowing MINORMASK as a maximum
Please remove the tab in "is	".

> value makes sense. It is also consistent with other "ida_.*MINORMASK" and
> "ida_*MINOR()" usages.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only, review with care for the upper bound change.

Tested on hw.

> ---
>   drivers/dma/idxd/cdev.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 0423655f5a88..b00926abc69a 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -165,7 +165,7 @@ static void idxd_cdev_dev_release(struct device *dev)
>   	struct idxd_wq *wq = idxd_cdev->wq;
>   
>   	cdev_ctx = &ictx[wq->idxd->data->type];
> -	ida_simple_remove(&cdev_ctx->minor_ida, idxd_cdev->minor);
> +	ida_free(&cdev_ctx->minor_ida, idxd_cdev->minor);
>   	kfree(idxd_cdev);
>   }
>   
> @@ -463,7 +463,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
>   	cdev = &idxd_cdev->cdev;
>   	dev = cdev_dev(idxd_cdev);
>   	cdev_ctx = &ictx[wq->idxd->data->type];
> -	minor = ida_simple_get(&cdev_ctx->minor_ida, 0, MINORMASK, GFP_KERNEL);
> +	minor = ida_alloc_max(&cdev_ctx->minor_ida, MINORMASK, GFP_KERNEL);
>   	if (minor < 0) {
>   		kfree(idxd_cdev);
>   		return minor;

Thanks.

-Fenghua