linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 21:22:35 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Zhenguo Yao <yaozhenguo1@...il.com>, srinivas.pandruvada@...ux.intel.com
Cc: lenb@...nel.org, rafael@...nel.org, viresh.kumar@...aro.org, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, yaozhenguo@...com
Subject: Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in
 no-HWP mode

On Wed, Dec 13, 2023 at 11:28 AM Zhenguo Yao <yaozhenguo1@...il.com> wrote:
>
> Users may disable HWP in firmware, in which case intel_pstate wouldn't load
> unless the CPU model is explicitly supported.
>
> See also the following past commits:
>
> commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids support
> in no-HWP mode")
> commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers support")
> commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support in
> no-HWP mode")
> commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in
> no-HWP mode")
> commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support in
> no-HWP mode")
>
> Signed-off-by: Zhenguo Yao <yaozhenguo1@...il.com>

Srinivas, any objections?

> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index a534a1f7f1ee..39e0a2cf7236 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2406,6 +2406,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
>         X86_MATCH(ICELAKE_X,            core_funcs),
>         X86_MATCH(TIGERLAKE,            core_funcs),
>         X86_MATCH(SAPPHIRERAPIDS_X,     core_funcs),
> +       X86_MATCH(EMERALDRAPIDS_X,      core_funcs),
>         {}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> --
> 2.39.3
>