linux-kernel - Re: [PATCH -v2 mm 2/4] kasan: handle concurrent kasan_record_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZfK9XZnLeVd_Qtc5UKBze_2pUVg_XPfqMiADSUx7FajqA@mail.gmail.com>
Date: Tue, 19 Dec 2023 22:19:43 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Marco Elver <elver@...gle.com>
Cc: andrey.konovalov@...ux.dev, Andrew Morton <akpm@...ux-foundation.org>, 
	Alexander Potapenko <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, Vlastimil Babka <vbabka@...e.cz>, 
	kasan-dev@...glegroups.com, Evgenii Stepanov <eugenis@...gle.com>, 
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Andrey Konovalov <andreyknvl@...gle.com>, 
	syzbot+186b55175d8360728234@...kaller.appspotmail.com
Subject: Re: [PATCH -v2 mm 2/4] kasan: handle concurrent kasan_record_aux_stack
 calls

On Thu, Dec 14, 2023 at 9:35 AM Marco Elver <elver@...gle.com> wrote:
>
> >  #if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS)
> > @@ -249,6 +250,7 @@ struct kasan_global {
> >  struct kasan_alloc_meta {
> >         struct kasan_track alloc_track;
> >         /* Free track is stored in kasan_free_meta. */
> > +       spinlock_t aux_lock;
>
> This needs to be raw_spinlock, because
> kasan_record_aux_stack_noalloc() can be called from non-sleepable
> contexts (otherwise lockdep will complain for RT kernels).

Right, will fix in v3. Thank you!