linux-kernel - Re: [PATCH] drivers: video: logo: use %u format specifier for unsigned int values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f3bb667-a458-432e-b6bc-1ae8c4277b8e@infradead.org>
Date: Tue, 19 Dec 2023 13:51:30 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Colin Ian King <colin.i.king@...il.com>, Helge Deller <deller@....de>,
 Nikita Romanyuk <ufh8945@...il.com>, linux-fbdev@...r.kernel.org,
 dri-devel@...ts.freedesktop.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: video: logo: use %u format specifier for
 unsigned int values



On 12/19/23 07:14, Colin Ian King wrote:
> Currently the %d format specifier is being used for unsigned int values.
> Fix this by using the correct %u format specifier. Cleans up cppcheck
> warnings:
> 
> warning: %d in format string (no. 1) requires 'int' but the argument
> type is 'unsigned int'. [invalidPrintfArgType_sint]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.

> ---
>  drivers/video/logo/pnmtologo.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/logo/pnmtologo.c b/drivers/video/logo/pnmtologo.c
> index ada5ef6e51b7..2434a25afb64 100644
> --- a/drivers/video/logo/pnmtologo.c
> +++ b/drivers/video/logo/pnmtologo.c
> @@ -249,10 +249,10 @@ static void write_footer(void)
>  	fputs("\n};\n\n", out);
>  	fprintf(out, "const struct linux_logo %s __initconst = {\n", logoname);
>  	fprintf(out, "\t.type\t\t= %s,\n", logo_types[logo_type]);
> -	fprintf(out, "\t.width\t\t= %d,\n", logo_width);
> -	fprintf(out, "\t.height\t\t= %d,\n", logo_height);
> +	fprintf(out, "\t.width\t\t= %u,\n", logo_width);
> +	fprintf(out, "\t.height\t\t= %u,\n", logo_height);
>  	if (logo_type == LINUX_LOGO_CLUT224) {
> -		fprintf(out, "\t.clutsize\t= %d,\n", logo_clutsize);
> +		fprintf(out, "\t.clutsize\t= %u,\n", logo_clutsize);
>  		fprintf(out, "\t.clut\t\t= %s_clut,\n", logoname);
>  	}
>  	fprintf(out, "\t.data\t\t= %s_data\n", logoname);

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html