linux-kernel - Re: [PATCH] samples/bpf: use %lu format specifier for unsigned long values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 14:02:25 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Colin Ian King <colin.i.king@...il.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, bpf@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples/bpf: use %lu format specifier for unsigned long
 values



On 12/19/23 07:23, Colin Ian King wrote:
> Currently %ld format specifiers are being used for unsigned long
> values. Fix this by using %lu instead. Cleans up cppcheck warnings:
> 
> warning: %ld in format string (no. 1) requires 'long' but the argument
> type is 'unsigned long'. [invalidPrintfArgType_sint]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  samples/bpf/cpustat_user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/bpf/cpustat_user.c b/samples/bpf/cpustat_user.c
> index ab90bb08a2b4..356f756cba0d 100644
> --- a/samples/bpf/cpustat_user.c
> +++ b/samples/bpf/cpustat_user.c
> @@ -66,10 +66,10 @@ static void cpu_stat_print(void)
>  
>  		printf("CPU-%-6d ", j);
>  		for (i = 0; i < MAX_CSTATE_ENTRIES; i++)
> -			printf("%-11ld ", data->cstate[i] / 1000000);
> +			printf("%-11lu ", data->cstate[i] / 1000000);
>  
>  		for (i = 0; i < MAX_PSTATE_ENTRIES; i++)
> -			printf("%-11ld ", data->pstate[i] / 1000000);
> +			printf("%-11lu ", data->pstate[i] / 1000000);
>  
>  		printf("\n");
>  	}

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html