linux-kernel - Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 08:22:01 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Daniel Díaz <daniel.diaz@...aro.org>,
	stable@...r.kernel.org, patches@...ts.linux.dev,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
	patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
	jonathanh@...dia.com, f.fainelli@...il.com,
	sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
	conor@...nel.org, allen.lkml@...il.com,
	Vegard Nossum <vegard.nossum@...cle.com>,
	Darren Kenny <darren.kenny@...cle.com>
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

On Tue, Dec 19, 2023 at 11:23:48AM +0530, Harshit Mogalapalli wrote:
> Hello Greg,
> 
> On 19/12/23 10:57 am, Daniel Díaz wrote:
> > Hello!
> > 
> 
> > 
> > -----8<-----
> >    In file included from /builds/linux/include/linux/list.h:9,
> >                     from /builds/linux/include/linux/module.h:9,
> >                     from /builds/linux/net/core/skbuff.c:41:
> >    /builds/linux/net/core/skbuff.c: In function 'skb_segment':
> >    /builds/linux/include/linux/kernel.h:847:43: warning: comparison of
> > distinct pointer types lacks a cast
> >      847 |                 (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> >          |                                           ^~
> >    /builds/linux/include/linux/kernel.h:861:18: note: in expansion of
> > macro '__typecheck'
> >      861 |                 (__typecheck(x, y) && __no_side_effects(x, y))
> >          |                  ^~~~~~~~~~~
> >    /builds/linux/include/linux/kernel.h:871:31: note: in expansion of
> > macro '__safe_cmp'
> >      871 |         __builtin_choose_expr(__safe_cmp(x, y), \
> >          |                               ^~~~~~~~~~
> >    /builds/linux/include/linux/kernel.h:880:25: note: in expansion of
> > macro '__careful_cmp'
> >      880 | #define min(x, y)       __careful_cmp(x, y, <)
> >          |                         ^~~~~~~~~~~~~
> >    /builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro
> > 'min'
> >     3630 |                 partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
> >          |                                ^~~
> > ----->8-----
> > 
> 
> Note:
> 
> Caused by this commit:
> 98c6fb04f83b net: prevent mss overflow in skb_segment()
> 
> I don't see this commit being queued in other stable branches yet, 5.4.y,
> 5.10.y, 5.15.y, 6.1.y, 6.6.y but only 4.19.y

Odd, Sasha, did something happen with your scripts?  I'll drop this from
4.19.y now, but it looks like it needs to be added to all branches.
Maybe because we don't really notice new build warnings on 4.19.y that
easily (due to so many of them), this got left in :(

thanks,

greg k-h