linux-kernel - Re: [PATCH] ntfs: dir.c: fix kernel-doc function parameter warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 16:45:21 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Anton Altaparmakov <anton@...era.com>, 
	linux-ntfs-dev@...ts.sourceforge.net, 
	Andrew Morton <akpm@...ux-foundation.org>, Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH] ntfs: dir.c: fix kernel-doc function parameter warnings

2023-12-19 13:54 GMT+09:00, Randy Dunlap <rdunlap@...radead.org>:
> Correct the kernel-doc function parameter warnings for function
> ntfs_dir_fsync() to prevent the following kernel-doc warnings:
>
> dir.c:1489: warning: Function parameter or member 'start' not described in
> 'ntfs_dir_fsync'
> dir.c:1489: warning: Function parameter or member 'end' not described in
> 'ntfs_dir_fsync'
> dir.c:1489: warning: Excess function parameter 'dentry' description in
> 'ntfs_dir_fsync'
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Anton Altaparmakov <anton@...era.com>
> Cc: Namjae Jeon <linkinjeon@...nel.org>
> Cc: linux-ntfs-dev@...ts.sourceforge.net
> Cc: Andrew Morton <akpm@...ux-foundation.org>
As you may already know, the same warning is probably coming from
ntfs_file_fsync() in file.c.
Reviewed-by: Namjae Jeon <linkinjeon@...nel.org>
Thanks!
> ---
>  fs/ntfs/dir.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/fs/ntfs/dir.c b/fs/ntfs/dir.c
> --- a/fs/ntfs/dir.c
> +++ b/fs/ntfs/dir.c
> @@ -1462,7 +1462,8 @@ static int ntfs_dir_open(struct inode *v
>  /**
>   * ntfs_dir_fsync - sync a directory to disk
>   * @filp:	directory to be synced
> - * @dentry:	dentry describing the directory to sync
> + * @start:	offset in bytes of the beginning of data range to sync
> + * @end:	offset in bytes of the end of data range (inclusive)
>   * @datasync:	if non-zero only flush user data and not metadata
>   *
>   * Data integrity sync of a directory to disk.  Used for fsync, fdatasync,
> and
>