linux-kernel - Re: [PATCH v2] fix overflow in idle exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e23ebdd8-7fbe-435b-a850-0ef18a51b020@collabora.com>
Date: Tue, 19 Dec 2023 11:56:37 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Bo Ye <bo.ye@...iatek.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: yongdong.zhang@...iatek.com, C Cheng <C.Cheng@...iatek.com>,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] fix overflow in idle exit_latency

Il 19/12/23 04:14, Bo Ye ha scritto:
> From: C Cheng <C.Cheng@...iatek.com>
> 
> In detail:
> 
> In C language, when you perform a multiplication operation, if
> both operands are of int type, the multiplication operation is
> performed on the int type, and then the result is converted to
> the target type. This means that if the product of int type
> multiplication exceeds the range that int type can represent,
>   an overflow will occur even if you store the result in a
> variable of int64_t type.
> 
> For a multiplication of two int values, it is better to use
> mul_u32_u32() rather than s->exit_latency_ns = s->exit_latency *
> NSEC_PER_USEC to avoid potential overflow happenning.
> 
> Signed-off-by: C Cheng <C.Cheng@...iatek.com>
> Signed-off-by: Bo Ye <bo.ye@...iatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>