linux-kernel - Re: [PATCH v6.8 2/2] nvmem: drop nvmem_layout_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09f433c0-72cd-4ebe-b405-4c9acc26e8fd@gmail.com>
Date: Tue, 19 Dec 2023 13:33:41 +0100
From: Rafał Miłecki <zajec5@...il.com>
To: Michael Walle <michael@...le.cc>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>, linux-mtd@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH v6.8 2/2] nvmem: drop nvmem_layout_get_match_data()

On 19.12.2023 13:21, Michael Walle wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>>
>> Thanks for layouts refactoring we now have "struct device" associated
>> with layout. Also its OF pointer points directly to the "nvmem-layout"
>> DT node.
>>
>> All it takes to get match data is a generic of_device_get_match_data().
> 
> Isn't device_get_match_data() preferred?

You're right. I think a big crusade against of_device_get_match_data()
is still ahead of us but I'll make sure to use device_get_match_data()
in U-Boot env layout to shine as an example :)


>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> Reviewed-by: Michael Walle <michael@...le.cc>

Thank you for quick reviews!