linux-kernel - [PATCH] sched/fair: Correct comment for enqueue_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202312192042+0800-wangjinchao@xfusion.com>
Date: Tue, 19 Dec 2023 20:43:53 +0800
From: Wang Jinchao <wangjinchao@...sion.com>
To: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot
	<vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel
 Gorman <mgorman@...e.de>, Daniel Bristot de Oliveira <bristot@...hat.com>,
	Valentin Schneider <vschneid@...hat.com>, <linux-kernel@...r.kernel.org>
CC: <stone.xulei@...sion.com>, <wangjinchao@...sion.com>
Subject: [PATCH] sched/fair: Correct comment for enqueue_task_fair

There is `add_nr_running(rq, 1);` in `enqueue_task_fair`, so the
original comment is confusing, correct it.

Signed-off-by: Wang Jinchao <wangjinchao@...sion.com>
---
 kernel/sched/fair.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d7a3c63a2171..0230f4594dfc 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6652,9 +6652,8 @@ static int sched_idle_cpu(int cpu)
 #endif
 
 /*
- * The enqueue_task method is called before nr_running is
- * increased. Here we update the fair scheduling stats and
- * then put the task into the rbtree:
+ * The enqueue_task method is called to update the fair scheduling stats 
+ * and put the task into the rbtree, and increase nr_running. 
  */
 static void
 enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
-- 
2.40.0