linux-kernel - Re: [PATCH] ASoC: xilinx: Embed IEC958 sample rate val to channel status register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d354ce4-b85c-495a-b54d-48a443736a52@sirena.org.uk>
Date: Tue, 19 Dec 2023 14:01:22 +0000
From: Mark Brown <broonie@...nel.org>
To: Sunil Vaghela <sunil.vaghela@...tnautics.com>
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	michal.simek@....com, linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ASoC: xilinx: Embed IEC958 sample rate val to channel
 status register

On Tue, Dec 19, 2023 at 05:59:55PM +0530, Sunil Vaghela wrote:
> As per IEC 60958 specification, bits 24 to 27 of channel status register
> indicates audio sample frequency. If these bits are not set, audio
> analyzer always shows 44.1KHz sample rate, irrespective of any sample
> rate audio is being played.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c: In function ‘xlnx_form
atter_pcm_hw_params’:
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:572:26: error: ‘struct 
xlnx_pcm_drv_data’ has no member named ‘nodes’
  572 |         if ((strstr(adata->nodes[XLNX_PLAYBACK]->name, "hdmi")) ||
      |                          ^~
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:572:34: error: ‘XLNX_PL
AYBACK’ undeclared (first use in this function)
  572 |         if ((strstr(adata->nodes[XLNX_PLAYBACK]->name, "hdmi")) ||
      |                                  ^~~~~~~~~~~~~
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:572:34: note: each unde
clared identifier is reported only once for each function it appears in
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:573:26: error: ‘struct xlnx_pcm_drv_data’ has no member named ‘nodes’
  573 |             (strstr(adata->nodes[XLNX_PLAYBACK]->name, "dp"))) {
      |                          ^~


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)