linux-kernel - Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 16:44:21 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Serge Semin <fancer.lancer@...il.com>
Cc: xiongxin <xiongxin@...inos.cn>, hoan@...amperecomputing.com,
	linus.walleij@...aro.org, brgl@...ev.pl, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	Riwen Lu <luriwen@...inos.cn>
Subject: Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it

On Tue, Dec 19, 2023 at 05:31:38PM +0300, Serge Semin wrote:
> On Tue, Dec 19, 2023 at 04:17:16PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 19, 2023 at 11:14 AM Serge Semin <fancer.lancer@...il.com> wrote:
> > > On Tue, Dec 19, 2023 at 09:37:51AM +0800, xiongxin wrote:
> > 
> > ...
> > 
> > > Also note all the tags you've already got must be preserved on the
> > > next patch revisions. One more time:
> > 
> > > Acked-by: Serge Semin <fancer.lancer@...il.com>
> > 
> > I recommend using `b4` for that.
> > 
> > it harvests tags from the email thread, so no need to care about
> > possible misses.
> 
> AFAICS it doesn't pick up the tags from the previous revisions at
> least if the new patch wasn't submitted as in-reply-to the prev one.

???

> Just tested it on v3. b4 found my new ab-tag only and no yours rb-tag.
> Did you mean something other than I thought you did?

Grabbing thread from lore.kernel.org/all/mdogxxro42ymeaykrgqpld2kqbppopbywcm76osskuf3df72sl@...lt26vzcv4/t.mbox.gz
Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
  [PATCH v2] gpio: dwapb: mask/unmask IRQ when disable/enale it
    + Reviewed-by: Andy Shevchenko <andy@...nel.org>
    + Acked-by: Serge Semin <fancer.lancer@...il.com> (✓ DKIM/gmail.com)

The flow you need to follow is that

	git checkout $BASE # gpio/for-next in this case
	b4 am ... # as above
	git am ...
	...address comments...
	git commit -a -s --amend
	git format-patch ... -1 HEAD~0
	git send-email ...

-- 
With Best Regards,
Andy Shevchenko