linux-kernel - Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error in sched_stat_wait trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 23:18:01 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: Junwen Wu <wudaemon@....com>
Cc: bristot@...hat.com, bsegall@...gle.com, dietmar.eggemann@....com, 
	juri.lelli@...hat.com, linux-kernel@...r.kernel.org, mgorman@...e.de, 
	mingo@...hat.com, peterz@...radead.org, rostedt@...dmis.org, 
	vincent.guittot@...aro.org, vschneid@...hat.com
Subject: Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error
 in sched_stat_wait trace_point

On Wed, Dec 20, 2023 at 10:33 PM Junwen Wu <wudaemon@....com> wrote:
>
> >>I think we'd better use if (!on_rt_rq(rt_se))
> >>
> >> +               update_stats_wait_end_rt(rt_rq, rt_se);
> >>
> hi, Yafang.when execute update_stats_dequeue_rt, rt_se->on_rq is still 0, util dequeue_rt_stack,
> the method is not effect.

Ah, you are right.

> I this we can use if (p && p != rq->curr) /*Mark the end of the wait period if dequeueing task*/

Agreed.

> because schedstats is not supported for rt group,we only need to update rt_se that is realy task.
> --
> Best regards
>


-- 
Regards
Yafang