linux-kernel - Re: [PATCH] thunderbolt: Reduce retry timeout to speed up boot for some devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e00a0dc-5911-44ee-8c50-a8482eb44197@tuxedocomputers.com>
Date: Wed, 20 Dec 2023 16:23:15 +0100
From: Werner Sembach <wse@...edocomputers.com>
To: Andreas Noever <andreas.noever@...il.com>,
 Michael Jamet <michael.jamet@...el.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Yehezkel Bernat <YehezkelShB@...il.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Reduce retry timeout to speed up boot for
 some devices

Am 20.12.23 um 16:09 schrieb Werner Sembach:
> This is a followup to "thunderbolt: Workaround an IOMMU fault on certain
> systems with Intel Maple Ridge".
>
> It seems like the timeout can be reduced to 250ms. This reduces the overall
> delay caused by the retires to ~1s. This is about the time other things
> being initialized in parallel need anyway*, so like this the effective boot
> time is no longer compromised.
>
> *I only had a single device available for my measurements: A Clevo X170KM-G
> desktop replacement notebook.
>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
I wonder if this could also land in stable? Or would it be to risky?
> ---
>   drivers/thunderbolt/icm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
> index d8b9c734abd36..56790d50f9e32 100644
> --- a/drivers/thunderbolt/icm.c
> +++ b/drivers/thunderbolt/icm.c
> @@ -1020,7 +1020,7 @@ icm_tr_driver_ready(struct tb *tb, enum tb_security_level *security_level,
>   
>   	memset(&reply, 0, sizeof(reply));
>   	ret = icm_request(tb, &request, sizeof(request), &reply, sizeof(reply),
> -			  1, 10, 2000);
> +			  1, 10, 250);
>   	if (ret)
>   		return ret;
>