linux-kernel - Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f55fa198-6a3f-4fa9-8633-e9557055d784@web.de>
Date: Wed, 20 Dec 2023 16:45:29 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Yazen Ghannam <yazen.ghannam@....com>, Borislav Petkov <bp@...en8.de>,
 linux-edac@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Avadhut Naik <avadhut.naik@....com>,
 John Allen <john.allen@....com>, Muralidhara M K <muralidhara.mk@....com>,
 Tony Luck <tony.luck@...el.com>, William Roche <william.roche@...cle.com>
Subject: Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library

…
> +++ b/drivers/ras/amd/atl/access.c
> @@ -0,0 +1,106 @@
…
> +static int __df_indirect_read(u16 node, u8 func, u16 reg, u8 instance_id, u32 *lo)
…

I suggest to reconsider the usage of double underscores for identifiers.
How do you think about to avoid that this software depends on undefined behaviour?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus