linux-kernel - Re: [PATCH 08/18] serial: sc16is7xx: add driver name to struct uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYMMs5A758h12AEM@smile.fi.intel.com>
Date: Wed, 20 Dec 2023 17:48:03 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, jringle@...dpoint.com,
	kubakici@...pl, phil@...pberrypi.org, bo.svangard@...eddedart.se,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH 08/18] serial: sc16is7xx: add driver name to struct
 uart_driver

On Tue, Dec 19, 2023 at 12:18:52PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> Make sure that the driver name is displayed instead of "unknown" when
> displaying the driver infos:
> 
> Before:
>     cat /proc/tty/drivers | grep ttySC
>     unknown              /dev/ttySC    243 0-7 serial
> 
> After:
>     cat /proc/tty/drivers | grep ttySC
>     sc16is7xx            /dev/ttySC    243 0-7 serial

"Useless use of cat" (you can google for this phrase, it's famous).

	grep ... /proc/...

will work :-)

Otherwise LGTM!

-- 
With Best Regards,
Andy Shevchenko