linux-kernel - Re: [PATCH RERESEND 04/11] tracing: tracing_buffers_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 11:41:04 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Ahelenia Ziemiańska
 <nabijaczleweli@...ijaczleweli.xyz>
Cc: Jens Axboe <axboe@...nel.dk>, Christian Brauner <brauner@...nel.org>,
 Alexander Viro <viro@...iv.linux.org.uk>, linux-fsdevel@...r.kernel.org,
 Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH RERESEND 04/11] tracing: tracing_buffers_splice_read:
 behave as-if non-blocking I/O

On Thu, 14 Dec 2023 19:45:02 +0100
Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz> wrote:

> Otherwise we risk sleeping with the pipe locked for indeterminate
> lengths of time.

This change log is really lacking.

Why is this an issue?

 
> Link: https://lore.kernel.org/linux-fsdevel/qk6hjuam54khlaikf2ssom6custxf5is2ekkaequf4hvode3ls@zgf7j5j4ubvw/t/#u

The change log should not rely on any external links. Those are for
reference only. At a bare minimum, the change log should have a tl;dr;
summary of the issue. The change log itself should have enough information
to understand why this change is happening without the need to look at any
links.

-- Steve