linux-kernel - Re: [PATCH v2 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZYMkJKYS+pRq1eMS@abdel>
Date: Wed, 20 Dec 2023 12:28:04 -0500
From: Abdel Alkuor <alkuor@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200
 temperature sensor

On Wed, Dec 20, 2023 at 05:16:08PM +0000, Conor Dooley wrote:
> On Wed, Dec 20, 2023 at 12:05:17PM -0500, Abdel Alkuor wrote:
> > On Wed, Dec 20, 2023 at 04:25:15PM +0000, Conor Dooley wrote:
> > > On Tue, Dec 19, 2023 at 11:27:29AM -0500, Abdel Alkuor wrote:
> > > > On Tue, Dec 19, 2023 at 03:18:24PM +0000, Conor Dooley wrote:
> > > > > On Sun, Dec 17, 2023 at 11:52:27PM -0500, Abdel Alkuor wrote:
> > > > >  
> > > > No, not all of them support the interrupt. Just tmp101, tmp102, tmp112, and as6200.
> > > > For now, I'll add the check for ams,as6200.
> > >
> > Hi Conor,
> > > If multiple devices have the interrupt you should document it for all of
> > > them IMO.
> > 
> > The interrupt hasn't been implemented for tmp101, tmp102 and tmp112 yet.
> > Should I still add them to the interrupt property? They might be two different
> > things driver and bindings, but I just wanted to make sure.
> 
> I don't really care if the driver supports the interrupt on any of the
> platforms (including the as6200), if the hardware has an interrupt the
> binding should reflect that :)

Understood. I'll add them in v4.

Abdel