linux-kernel - Re: [PATCH v6 4/5] dm verity: Fix I/O priority lost when read FEC and hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220183255.GA119068@quark.localdomain>
Date: Wed, 20 Dec 2023 12:32:55 -0600
From: Eric Biggers <ebiggers@...nel.org>
To: Hongyu Jin <hongyu.jin.cn@...il.com>
Cc: agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com,
	axboe@...nel.dk, zhiguo.niu@...soc.com, ke.wang@...soc.com,
	yibin.ding@...soc.com, hongyu.jin@...soc.com,
	linux-kernel@...r.kernel.org, dm-devel@...ts.linux.dev,
	linux-block@...r.kernel.org
Subject: Re: [PATCH v6 4/5] dm verity: Fix I/O priority lost when read FEC
 and hash

On Wed, Dec 20, 2023 at 06:03:32PM +0800, Hongyu Jin wrote:
> +static inline struct dm_verity_io *verity_io(struct dm_verity *v, struct dm_verity_fec_io *fio)
> +{
> +	return (struct dm_verity_io *)
> +		((char *)fio + sizeof(struct dm_verity_fec_io) - v->ti->per_io_data_size);
> +}
[...]
> @@ -129,8 +136,10 @@ static int fec_decode_bufs(struct dm_verity *v, struct dm_verity_fec_io *fio,
>  	struct dm_buffer *buf;
>  	unsigned int n, i, offset;
>  	u8 *par, *block;
> +	struct dm_verity_io *io = verity_io(v, fio);
> +	struct bio *bio = dm_bio_from_per_bio_data(io, v->ti->per_io_data_size);

How about passing 'io' as an argument to fec_decode_bufs() instead of adding the
verity_io() helper function?

- Eric