linux-kernel - Re: [PATCH] kernel: relay: remove relay_file_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3jyl25fuzazy24hccrnceu5h7phx2f4qjdpbrfaiuu7hgryzm5@tarta.nabijaczleweli.xyz>
Date: Wed, 20 Dec 2023 03:21:14 +0100
From: наб <nabijaczleweli@...ijaczleweli.xyz>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Li kunyu <kunyu@...china.com>, Zhao Lei <zhao_lei1@...erun.com>, 
	"Mike Rapoport (IBM)" <rppt@...nel.org>, Suren Baghdasaryan <surenb@...gle.com>, 
	Zhang Zhengming <zhang.zhengming@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: relay: remove relay_file_splice_read ‒ dead code, doesn't work

On Tue, Dec 19, 2023 at 04:35:54PM -0800, Andrew Morton wrote:
> On Tue, 19 Dec 2023 23:24:14 +0100 Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz> wrote:
> > shows it just doesn't work, and splicing always instantly returns empty
> > (subsequent reads actually return the contents).
> > 
> > No-one noticed it became dead code in 2016, who knows if it worked back
> > then. Clearly no-one cares; just delete it.
> All checks out for me.  How on earth did you notice this?
Trying to explicitly trigger every .splice_read callback to test patches for
  https://nabijaczleweli.xyz/content/blogn_t/011-linux-splice-exclusion.html

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)