linux-kernel - Re: [PATCH] drivers: of: Fixed kernel doc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e1e12d5-041c-4263-a522-c8079f4ed5a1@infradead.org>
Date: Tue, 19 Dec 2023 18:37:23 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Muhammad Muzammil <m.muzzammilashraf@...il.com>, robh+dt@...nel.org,
 frowand.list@...il.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: of: Fixed kernel doc warning



On 12/18/23 22:23, Muhammad Muzammil wrote:
> From: Muzammil Ashraf <m.muzzammilashraf@...il.com>
> 
> property.c:1220 : Fixed excess struct member definition warning
> property.c:444 	: Fixed missing a blank line after declarations
> 

Nit: only one of those is a kernel-doc warning.

> Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@...il.com>
> ---
>  drivers/of/property.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index afdaefbd03f6..641a40cf5cf3 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -441,6 +441,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
>  				const char **out_string)
>  {
>  	const struct property *prop = of_find_property(np, propname, NULL);
> +
>  	if (!prop)
>  		return -EINVAL;
>  	if (!prop->length)
> @@ -1217,9 +1218,9 @@ static struct device_node *parse_##fname(struct device_node *np,	     \
>   *
>   * @parse_prop: function name
>   *	parse_prop() finds the node corresponding to a supplier phandle
> - * @parse_prop.np: Pointer to device node holding supplier phandle property
> - * @parse_prop.prop_name: Name of property holding a phandle value
> - * @parse_prop.index: For properties holding a list of phandles, this is the
> + *  parse_prop.np: Pointer to device node holding supplier phandle property
> + *  parse_prop.prop_name: Name of property holding a phandle value
> + *  parse_prop.index: For properties holding a list of phandles, this is the
>   *		      index into the list

Looks good. Thanks.

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

>   * @optional: Describes whether a supplier is mandatory or not
>   * @node_not_dev: The consumer node containing the property is never converted

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html