linux-kernel - Re: [PATCH 0/3] Add mediatek,gce-events definition to mediatek,gce-mailbox bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 02:46:03 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "conor@...nel.org" <conor@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Johnson Wang (王聖鑫) <Johnson.Wang@...iatek.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"jason-jh.lin@...iatek.corp-partner.google.com"
	<jason-jh.lin@...iatek.corp-partner.google.com>,
	Jason-ch Chen (陳建豪)
	<Jason-ch.Chen@...iatek.com>, Shawn Sung (宋孝謙)
	<Shawn.Sung@...iatek.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "jassisinghbrar@...il.com"
	<jassisinghbrar@...il.com>, "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 0/3] Add mediatek,gce-events definition to
 mediatek,gce-mailbox bindings

Hi Conor,

Thanks for the reviews.

On Tue, 2023-12-19 at 16:54 +0000, Conor Dooley wrote:
> On Mon, Dec 18, 2023 at 04:36:01PM +0800, Jason-JH.Lin wrote:
> > From: Jason-jh Lin <jason-jh.lin@...iatek.corp-partner.google.com>
> > 
> > Since mediatek,gce-events property is a HW event signal from GCE,
> > it should be defined in mediatek,gce-mailbox.yaml.
> > 
> > Change the description of mediatek,gce-events property existed in
> > other bindings to reference mediatek,gce-mailbox.yaml.
> 
> I don't understand this series. I would understand it if the property
> should be related to the mailbox provider and it is moved there from
> the
> mailbox consumer, but this series does not do that. Instead the
> series
> now documents this property for both consumers and providers.
I want to move properties related to MediaTek's proprietary GCE HW to a
common place and let it referenced by mailbox providers and consumers.

And I also want to add this property into a mailbox provider, but maybe
not in this series. I'll move this modification into another series.

> 
> Secondly it removes the typedef from the consumers, which makes no
> sense
> if this is a valid property there.
> 
OK, I will keep the $ref for the consumers.

> Is your intention to document a property that should be common across
> all consumers in a single place? If that is your goal, then something
> like spi-peripheral-props.yaml is what you need here.
> 
Thanks for your example.

Since these properties for the GCE HW are MediaTek specific, I will try
to send a series to create a mediatek,gce-props.yaml to list all these
properties. And modify all these properties in mailbox consumers.

Regards,
Jason-JH.Lin

> Confused,
> Conor.