linux-kernel - Re: [PATCH v3 2/3] usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 06:57:54 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc: Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Mathias Nyman <mathias.nyman@...el.com>, linux-usb@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Eddie Hung <eddie.hung@...iatek.com>,
	Macpaul Lin <macpaul.lin@...iatek.com>, stable@...r.kernel.org
Subject: Re: [PATCH v3 2/3] usb: xhci-mtk: fix a short packet issue of gen1
 isoc-in transfer

On Wed, Dec 20, 2023 at 10:58:41AM +0800, Chunfeng Yun wrote:
> For Gen1 isoc-in transfer, host still send out unexpected ACK after device
> finish the burst with a short packet, this will cause an exception on the
> connected device, such as, a usb 4k camera.
> It can be fixed by setting rxfifo depth less than 4k bytes, prefer to use
> 3k here, the side-effect is that may cause performance drop about 10%,
> including bulk transfer.
> 
> Fixes: 926d60ae64a6 ("usb: xhci-mtk: modify the SOF/ITP interval for mt8195")
> Cc: stable@...r.kernel.org
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> ---
> v3:
> add Cc stable

Why is a patch that you are marking for stable inclusion (and I am
guessing inclusion in 6.7-final) in the middle of other patches that are
not marked as such?

Always split out bugfixes from other things so that they can go through
the two different branches, one for this current release, and one for
the next one.

Otherwise you will have to wait until 6.8-rc1 for this bugfix to land,
which I doubt you intend to have happen.

Please fix up and resend 2 different patch series.

thanks,

greg k-h