linux-kernel - Re: [PATCH 1/3] dt-bindings: mailbox: mediatek,gce-mailbox: Add mediatek,gce-events definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cafae4ec-337a-4134-8545-d86c4c61c858@linaro.org>
Date: Wed, 20 Dec 2023 08:07:33 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Jason-JH.Lin" <jason-jh.lin@...iatek.com>,
 Jassi Brar <jassisinghbrar@...il.com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Chun-Kuang Hu <chunkuang.hu@...nel.org>
Cc: Conor Dooley <conor+dt@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-media@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Jason-ch Chen <jason-ch.chen@...iatek.com>,
 Johnson Wang <johnson.wang@...iatek.com>,
 Singo Chang <singo.chang@...iatek.com>, Nancy Lin <nancy.lin@...iatek.com>,
 Shawn Sung <shawn.sung@...iatek.com>,
 Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 1/3] dt-bindings: mailbox: mediatek,gce-mailbox: Add
 mediatek,gce-events definition

On 18/12/2023 09:36, Jason-JH.Lin wrote:
> Since mediatek,gce-events property is a HW event signal from GCE,
> it should be defined in mediatek,gce-mailbox.yaml and change the

Why? None of the bindings reference it. Did you just move property from
one device to completely different one?

> description of mediatek,gce-events property in other bindings to
> reference mediatek,gce-mailbox.yaml.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> ---
>  .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml  | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> index cef9d7601398..e4da0a58c943 100644
> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> @@ -49,6 +49,13 @@ properties:
>      items:
>        - const: gce
>  
> +  mediatek,gce-events:
> +    description:
> +      The event id which is mapping to the specific hardware event signal
> +      to gce. The event id is defined in the gce header
> +      include/dt-bindings/gce/<chip>-gce.h of each chips.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array

Where are the constraints?

Best regards,
Krzysztof