linux-kernel - Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220081717.0afc17f3@xps-13>
Date: Wed, 20 Dec 2023 08:17:17 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Rafał Miłecki <zajec5@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Srinivas Kandagatla
 <srinivas.kandagatla@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Michael Walle <michael@...le.cc>,
 linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 u-boot@...ts.denx.de, Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem
 helpers

Hi Rafał,

zajec5@...il.com wrote on Tue, 19 Dec 2023 19:16:37 +0100:

> On 19.12.2023 19:13, Greg Kroah-Hartman wrote:
> > On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote:  
> >> From: Rafał Miłecki <rafal@...ecki.pl>
> >>
> >> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less
> >>     mtd dependent
> >> 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells  
> > 
> > Shouldn't this be 2 different patches?  
> 
> I used to maintainers complaining my patches are too small and not the
> other way ;) I think it happened two or three times with mtd subsys.

A single patch may be too small if it's alone and we don't see the big
picture, otherwise I have no issue with small patches, do I? Anyway, in
this case I don't mind the patch being split or kept like this, just
keep my R-by applied to both if you do indeed split.

Thanks,
Miquèl