linux-kernel - Re: [RESEND PATCH] leds: ledtrig-pattern: Use last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZYKh-F-1psKpm1JA@hovoldconsulting.com>
Date: Wed, 20 Dec 2023 09:12:40 +0100
From: Johan Hovold <johan@...nel.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: phone-devel@...r.kernel.org, Pavel Machek <pavel@....cz>,
	Bjorn Andersson <bjorn.andersson@...aro.org>,
	~postmarketos/upstreaming@...ts.sr.ht,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>,
	Konrad Dybcio <konrad.dybcio@...ainline.org>,
	Martin Botka <martin.botka@...ainline.org>,
	Jami Kettunen <jami.kettunen@...ainline.org>,
	linux-arm-msm@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when
 applying hw pattern

On Tue, Jul 19, 2022 at 11:30:33PM +0200, Marijn Suijten wrote:
> `last_repeat` holds the actual value requested by the user whereas
> `repeat` is a software iteration variable that is unused in hardware
> patterns.
> 
> Furthermore `last_repeat` is the field returned to the user when reading
> the `repeat` sysfs property.  This field is initialized to `-1` which is
> - together with `1` - the only valid value in the upcoming Qualcomm LPG
> driver.  It is thus unexpected when `repeat` with an initialization
> value of `0` is passed into the the driver, when the sysfs property
> clearly presents a value of `-1`.
> 
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Tested-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Looks correct to me:

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>