linux-kernel - Re: [PATCH] dt-bindings: firmware: xilinx: Describe missing child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5be15b6f-ac6e-4cab-bd83-ef3fa50e1886@linaro.org>
Date: Wed, 20 Dec 2023 09:18:28 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org,
 monstr@...str.eu, michal.simek@...inx.com, git@...inx.com
Cc: Conor Dooley <conor+dt@...nel.org>, Guenter Roeck <linux@...ck-us.net>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Naman Trivedi Manojbhai <naman.trivedimanojbhai@....com>,
 Rob Herring <robh+dt@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Shubhrajyoti Datta <shubhrajyoti.datta@....com>, devicetree@...r.kernel.org,
 kishore Manne <nava.kishore.manne@....com>,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Describe missing child
 nodes

On 20/12/2023 08:57, Michal Simek wrote:
> 
> 
> On 12/20/23 08:53, Krzysztof Kozlowski wrote:
>> On 19/12/2023 15:54, Michal Simek wrote:
>>> Firmware node has more than fpga, aes and clock child nodes but also power,
>>> reset, gpio, pinctrl and pcap which are not described yet.
>>> All of them have binding in separate files but there is missing connection
>>> to firmware node that's why describe it.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@....com>
>>> ---
>>>
>>>   .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 31 +++++++++++++++++++
>>>   1 file changed, 31 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>>> index 3d578f98ae2c..0662544f86f0 100644
>>> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>>> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>>> @@ -53,6 +53,37 @@ properties:
>>>         vector.
>>>       type: object
>>>   
>>> +  zynqmp-power:
>>
>> Can we rename it to "power-management" or if it is a power-domain
>> provider to "power-controller"? Assuming nothing requires the old name?
> 
> I don't think there is any name dependency and node name can be renamed.
> 
>>
>> Also, all these nodes/properties look like not ordered by name, so maybe
>> it is possible to add new nodes in some order?
> 
> I am fine with it. Do you want to sort it before adding new one or add new one 
> and sort of all them?

Maybe the new properties can be added not in one chunk but
as-ordered-as-possible?

Best regards,
Krzysztof